Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for trainer image #69

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

tharapalanivel
Copy link
Collaborator

Description of the change

Open source sft-trainer Dockerfile and launch_training script

Related issue number

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

Signed-off-by: Thara Palanivel <[email protected]>

Co-authored-by: Kelly A <[email protected]>
Co-authored-by: Anh-Uong <[email protected]>
Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thara! I think using a build directory instead of training_image directory could be better

trainer_image/Dockerfile Outdated Show resolved Hide resolved
@anhuong
Copy link
Collaborator

anhuong commented Mar 4, 2024

Also the format linter failed, please try running tox -e fmt to fix errors found in launch_training script.

build/Dockerfile Show resolved Hide resolved
Signed-off-by: Thara Palanivel <[email protected]>
@tharapalanivel tharapalanivel requested a review from anhuong March 5, 2024 07:22
Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thara!

@anhuong anhuong merged commit 0e60ecd into foundation-model-stack:main Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants